config: update rc branch naming and sanitize input #7869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
tsmithsz
changed the title
tsmithsz
changed the title
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
chungjac
approved these changes
Aug 12, 2025
tsmithsz
force-pushed
the
release-naming
branch
from
3c9a569 to
1a4ed8c
Compare
tsmithsz
changed the title
bywang56
reviewed
Aug 12, 2025
yueny2020
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The prerelease workflow is configured to run on branches matching release/*. The RC creation workflow previously created branches like
rc-YYYYMMDDinstead ofrelease/rc-YYMMDD, which did not match the trigger pattern, meaning the prerelease workflow was never invoked automatically.As it stands now any team member with write access can perform workflow_dispatch injection.
Solution
Update the RC creation workflow to create branches in the format
release/rc-YYYYMMDDinstead ofrc-YYYYMMDD, ensuring they match the prerelease workflow’srelease/*branch trigger and are picked up for prerelease builds.Sanitize the input fields via Github environment variables
feature/xbranches will not be squash-merged at release time.